-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer socketmode #1150
Safer socketmode #1150
Commits on Dec 20, 2022
-
socketmode.Client.run: Fix slack-go#1125 by allowing producer of chan…
…nel to close when it is finished, and consumer to see the close
Configuration menu - View commit details
-
Copy full SHA for 32bb00d - Browse repository at this point
Copy the full SHA 32bb00dView commit details -
socketmode.Client.run: Fix small race potential on 'firstErr' as the …
…outer goroutine did not wait on all inner goroutines that had a chance to set it, also make sure to check error for context.Canceled appropriately
Configuration menu - View commit details
-
Copy full SHA for c6ed812 - Browse repository at this point
Copy the full SHA c6ed812View commit details -
socketmode.Client.Events: Change all events produced to Events channe…
…l via a method that has an escape hatch; unable to change public Events field without breaking api, though
Configuration menu - View commit details
-
Copy full SHA for 0254b8f - Browse repository at this point
Copy the full SHA 0254b8fView commit details -
socketmode.Client.run: Cover edge case where all goroutines exit nil,…
… when getting buffered (first) error
Configuration menu - View commit details
-
Copy full SHA for 25f2f6e - Browse repository at this point
Copy the full SHA 25f2f6eView commit details -
socketmode: Slight refactor of Send/Ack on Client to allow passing co…
…ntexts for channel ops, though they are very similar now
Configuration menu - View commit details
-
Copy full SHA for bb28237 - Browse repository at this point
Copy the full SHA bb28237View commit details -
socketmode: Shore up error handling via errors.Is/As/(Un)Wrapping, ot…
…her small changes
Configuration menu - View commit details
-
Copy full SHA for 377ffe4 - Browse repository at this point
Copy the full SHA 377ffe4View commit details
Commits on Apr 24, 2023
-
Merge remote-tracking branch 'upstream/master' into safer-socketmode
Functionally revert slack-go#1170 as drafted approach takes correct path of closing chan on goroutine producer side
Configuration menu - View commit details
-
Copy full SHA for 8c8b886 - Browse repository at this point
Copy the full SHA 8c8b886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5babfb7 - Browse repository at this point
Copy the full SHA 5babfb7View commit details -
Fix race on deadman timer Elapsed+Reset by more efficient use of tick…
…er and ping time channel. Remove deadman file as it is no longer needed
Configuration menu - View commit details
-
Copy full SHA for 4dd1a1f - Browse repository at this point
Copy the full SHA 4dd1a1fView commit details