Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer socketmode #1150

Merged
merged 9 commits into from
Aug 24, 2023
Merged

Safer socketmode #1150

merged 9 commits into from
Aug 24, 2023

Commits on Dec 20, 2022

  1. socketmode.Client.run: Fix slack-go#1125 by allowing producer of chan…

    …nel to close when it is finished, and consumer to see the close
    iaburton committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    32bb00d View commit details
    Browse the repository at this point in the history
  2. socketmode.Client.run: Fix small race potential on 'firstErr' as the …

    …outer goroutine did not wait on all inner goroutines that had a chance to set it, also make sure to check error for context.Canceled appropriately
    iaburton committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    c6ed812 View commit details
    Browse the repository at this point in the history
  3. socketmode.Client.Events: Change all events produced to Events channe…

    …l via a method that has an escape hatch; unable to change public Events field without breaking api, though
    iaburton committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    0254b8f View commit details
    Browse the repository at this point in the history
  4. socketmode.Client.run: Cover edge case where all goroutines exit nil,…

    … when getting buffered (first) error
    iaburton committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    25f2f6e View commit details
    Browse the repository at this point in the history
  5. socketmode: Slight refactor of Send/Ack on Client to allow passing co…

    …ntexts for channel ops, though they are very similar now
    iaburton committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    bb28237 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    377ffe4 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge remote-tracking branch 'upstream/master' into safer-socketmode

    Functionally revert slack-go#1170 as drafted approach takes correct path of
    closing chan on goroutine producer side
    iaburton committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8c8b886 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5babfb7 View commit details
    Browse the repository at this point in the history
  3. Fix race on deadman timer Elapsed+Reset by more efficient use of tick…

    …er and ping time channel. Remove deadman file as it is no longer needed
    iaburton committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4dd1a1f View commit details
    Browse the repository at this point in the history