Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add omitempty to ConfirmationBlockObject.Deny #1224

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

kamil-gwozdz
Copy link
Contributor

This PR adds omitempty to ConfirmationBlockObject.Deny.

It's not a required field and without omitempty a null ends up being generated in the json payload, which is not accepted by the schema. This means that, with the current version of the client, it's not possible to omit the deny button.

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parsley42 parsley42 merged commit 49c50d0 into slack-go:master Aug 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants