Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Add support for Client Certificates for MQTT and disabling Retained messages #151

Merged
merged 17 commits into from
Jan 16, 2022

Conversation

prestomation
Copy link
Contributor

@prestomation prestomation commented Dec 24, 2021

For my usecase, I want to connect to a cloud broker(AWS IoT). This service uses Client Certificates. AWS IoT has an incomplete MQTT implementation and does not support QoS (Exactly Once). It also does not support Retain messages in LWT and other situations.

This change is to get feedback on how we prefer to deal with these configuration edge cases. It's not clear to me that QoS2 is actually useful because of how HWS republishes all messages on a recurring basis. Should we add additional options for supporting Retains/QoS2? Should we remove the use of QoS2 and make the option I've already added apply to all retains?

Additionally, I'm having some problems with the UI. I am not familiar with this UI framework, but the second new textbox and save button are now out of frame/invisible in my build. It looks like there should be a scrollbar, so not sure of the best way to fix this.

Testing:
I have this working with AWS IoT in my AWS account. I have configured my HomeAssistant mosquitto broker to bridge to AWS IoT and my HWS sensors are working great.

SecretiveShell and others added 17 commits October 30, 2021 12:59
Created a FAQ section to solve some common problems
Added another YouTube video and collapsed the screenshots.
… are slightly outdated, but I hope they are useful.
The explanation to WebcamActive/MicrophoneActive was mixed up, 
fixed this.
Fixing Webcam/Microphone Sensor mixup in Readme
Expand on using TLS
Added a few more articles to the "in the press" section. Some of them…
…essages

For my usecase, I want to connect to a cloud broker(AWS IoT). This service uses Client Certificates. AWS IoT has an incomplete MQTT implementation and does not support QoS (Exactly Once). It also does not support Retain messages in LWT and other situations.

This change is to get feedback on how we prefer to deal with these configuration edge cases. It's not clear to me that QoS2 is actually useful because of how HWS republishes all messages on a recurring basis.  Should we add additional options for supporting Retains/QoS2? Should we remove the use of QoS2 and make the option I've already added apply to all retains?

Additionally, I'm having some problems with the UI. I am not familiar with this UI framework, but the second new textbox and save button are now out of frame/invisible in my build. It looks like there should be a scrollbar, so not sure of the best way to fix this.

Testing:
I have this working with AWS IoT in my AWS account. I have configured my HomeAssistant mosquitto broker to bridge to AWS IoT and my HWS sensors are working great.
@sleevezipper
Copy link
Owner

Thank you so much! This looks great! I'll get back to you this weekend.

I'm working on the UI so everything will be reachable.

@sleevezipper sleevezipper changed the base branch from master to develop January 16, 2022 11:10
@sleevezipper sleevezipper merged commit 77cf49f into sleevezipper:develop Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants