Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken escaping of role title #116

Open
kdeldycke opened this issue Oct 9, 2021 · 0 comments
Open

Broken escaping of role title #116

kdeldycke opened this issue Oct 9, 2021 · 0 comments

Comments

@kdeldycke
Copy link

Simple working case

Here is a couple of sphinx-issues roles in rST:

:issue:`17`

:commit:`170ce9`

This works great and is rendered as such in HTML:

<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/issues/17">#17</a>
</p>
<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/commit/170ce9">170ce9</a>
</p>

Perfect! 😎👍

Broken escaping

But when I try to use the :role:`title <target>` schema like so:

:issue:`Issue #17 (the big one) <17>`

:commit:`1.0.0 (2016-07-05) <170ce9>`

Then the results gets mangled:

<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/issues/Issue #17 (the big one) &lt;17&gt;">#Issue #17 (the big one) &lt;17&gt;</a>
</p>
<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/commit/1.0.0 (2016-07-05) &lt;170ce9&gt;">1.0.0 (</a>
</p>

Expected result

Here is what I expect the resulting HTML to look like:

<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/issues/17">Issue #17 (the big one)</a>
</p>
<p>
  <a href="https://github.com/kdeldycke/meta-package-manager/commit/170ce9">1.0.0 (2016-07-05)</a>
</p>
kdeldycke added a commit to kdeldycke/meta-package-manager that referenced this issue Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant