Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linking to CWEs #122

Merged
merged 2 commits into from
Jan 1, 2022
Merged

Support linking to CWEs #122

merged 2 commits into from
Jan 1, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 24, 2021

Add support for linking to CWE numbers at https://cwe.mitre.org, such as CWE-787 at https://cwe.mitre.org/data/definitions/787.html with:

:cwe:`CWE-787`

The structure is similar to CVEs.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 1, 2022

@sloria I have a security release scheduled for tomorrow, it would be great to use this in the release notes. Any chance of a release with this today?

Thank you and happy new year!

Copy link
Owner

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks


target = utils.unescape(target).strip()
title = utils.unescape(title).strip()
number = target[4:]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): would it make sense to also support :cwe:787 here?

no need to do this now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do! But should we also support this?

:cve:`2018-17175`

In addition to the current:

:cve:`CVE-2018-17175`

@sloria sloria merged commit 118fa78 into sloria:master Jan 1, 2022
@sloria
Copy link
Owner

sloria commented Jan 1, 2022

This is released in 2.0.0

@hugovk hugovk deleted the add-cwe branch January 1, 2022 14:24
@hugovk
Copy link
Contributor Author

hugovk commented Jan 1, 2022

Thank you!

@hugovk hugovk mentioned this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants