Fix slack notifications for automation workflows

smartcontractkit · Sep 17, 2024 · 43bfc9a · 43bfc9a
1 parent a52e9df
commit 43bfc9a
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/.github/workflows/automation-benchmark-tests.yml b/.github/workflows/automation-benchmark-tests.yml
@@ -15,6 +15,11 @@ on:
         default: develop
         required: true
         type: string
+      slackMemberID:
+        description: Notifies test results (Not your @)
+        required: true
+        default: U02Q14G80TY
+        type: string     
 
 jobs:
   run-e2e-tests-workflow:
@@ -24,7 +29,8 @@ jobs:
       test_ids: 'benchmark/keeper_test.go:TestAutomationBenchmark'
       test_config_override_path: ${{ inputs.test_config_override_path }}
       chainlink_version: ${{ github.sha }}
-      slack_notification_after_tests_channel_id: C03KJ5S7KEK
+      SLACK_USER: ${{ inputs.slackMemberID }}
+      SLACK_CHANNEL: C03KJ5S7KEK
     secrets:
       QA_AWS_REGION: ${{ secrets.QA_AWS_REGION }}
       QA_AWS_ROLE_TO_ASSUME: ${{ secrets.QA_AWS_ROLE_TO_ASSUME }}

diff --git a/.github/workflows/automation-load-tests.yml b/.github/workflows/automation-load-tests.yml
@@ -9,7 +9,12 @@ on:
       test_secrets_override_key:
         description: 'Key to run tests with custom test secrets'
         required: false
-        type: string 
+        type: string
+      slackMemberID:
+        description: Notifies test results (Not your @)
+        required: true
+        default: U02Q14G80TY
+        type: string         
 
 jobs:
   run-e2e-tests-workflow:
@@ -19,7 +24,8 @@ jobs:
       test_ids: 'load/automationv2_1/automationv2_1_test.go:TestLogTrigger'
       test_config_override_path: ${{ inputs.test_config_override_path }}
       chainlink_version: ${{ github.sha }}
-      slack_notification_after_tests_channel_id: C03KJ5S7KEK
+      SLACK_USER: ${{ inputs.slackMemberID }}
+      SLACK_CHANNEL: C03KJ5S7KEK
     secrets:
       QA_AWS_REGION: ${{ secrets.QA_AWS_REGION }}
       QA_AWS_ROLE_TO_ASSUME: ${{ secrets.QA_AWS_ROLE_TO_ASSUME }}

diff --git a/.github/workflows/run-e2e-tests-reusable-workflow.yml b/.github/workflows/run-e2e-tests-reusable-workflow.yml
@@ -121,6 +121,14 @@ on:
         required: false
         type: boolean
         default: false
+      SLACK_CHANNEL:
+        description: 'SLACK_CHANNEL env used to send Slack notifications from test code'
+        required: false
+        type: string        
+      SLACK_USER:
+        description: 'SLACK_USER env used to send Slack notifications from test code'
+        required: false
+        type: string  
     outputs:
       test_results:
         description: 'Test results from all executed tests'
@@ -181,7 +189,8 @@ env:
   TEST_LOG_LEVEL: ${{ inputs.test_log_level }}
   METRICS_COLLECTION_ID: chainlink-e2e-tests
   SLACK_API_KEY: ${{ secrets.SLACK_API_KEY }}
-  SLACK_CHANNEL: ${{ inputs.slack_notification_after_tests_channel_id || secrets.SLACK_CHANNEL }}
+  SLACK_CHANNEL: ${{ inputs.slack_notification_after_tests_channel_id || inputs.SLACK_CHANNEL || secrets.SLACK_CHANNEL }}
+  SLACK_USER: ${{ inputs.SLACK_USER }}
 
 jobs:
   validate-inputs: