Get request logs from past n blocks #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
bolekk
requested changes
Oct 25, 2023
bolekk
requested changes
Oct 26, 2023
| logPollerCacheDurationSec := int64(pluginConfig.LogPollerCacheDurationSec) | ||
| if logPollerCacheDurationSec <= 0 { | ||
| lggr.Warnw("invalid logPollerCacheDuration, using 300 instead", "logPollerCacheDurationSec", logPollerCacheDurationSec) | ||
| logPollerCacheDurationSec = 300 |
There was a problem hiding this comment.
Can you explain what you mean by const here? I'm not understanding why this should be a const variable.
There was a problem hiding this comment.
Bolek probably means because this is a magic number we should instead set it to a more descriptive named const such as const PastBlocksToPoll = 50. My personal preferenece would also be to pull this either the top of the file or to a constants area for easy reference and changing.
| pastBlocksToPoll := int64(pluginConfig.PastBlocksToPoll) | ||
| if pastBlocksToPoll <= 0 { | ||
| lggr.Warnw("invalid pastBlocksToPoll, using 50 instead", "pastBlocksToPoll", pastBlocksToPoll) | ||
| pastBlocksToPoll = 50 |
bolekk
requested changes
Oct 30, 2023
KuphJr
force-pushed
the
fix/functions-reorg-handling-logpoller
branch
from
0dc1baf
to
8b98b57
Compare
bolekk
previously approved these changes
Oct 31, 2023
| return resultsReq, resultsResp, nil | ||
| } | ||
|
|
||
| func (l *logPollerWrapper) FilterPreviouslyDetectedEvents(logs []logpoller.Log, detectedEvents *detectedEvents, filterType string) []logpoller.Log { | ||
| if len(logs) > maxLogsToProcess { | ||
| l.lggr.Warnw("FilterPreviouslyDetectedEvents: too many logs to process, only processing latest maxLogsToProcess logs", "filterType", filterType, "nLogs", len(logs), "maxLogsToProcess", maxLogsToProcess) |
bolekk
previously approved these changes
Oct 31, 2023
|
SonarQube Quality Gate
|
bolekk
approved these changes
Oct 31, 2023
bolekk
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Get request logs from past n blocks * Separate confirmations setting for reqs & resps * Filter already detected reqs & resps * validate pastBlocksToPoll * Fixed bugs which appeared during tests * Addressed feedback * Added test * Added comment to config * Fixed log & removed const * Used const values for defaults * Address feedback * Fixed types for logPoller * Added tests for FilterPreviouslyDetectedEvents * Added additional test assertions * Fixed lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.