Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilizes Lazier Fund Return for Tests #11144

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Utilizes Lazier Fund Return for Tests #11144

merged 1 commit into from
Nov 1, 2023

Conversation

kalverra
Copy link
Collaborator

@kalverra kalverra commented Nov 1, 2023

Also a little housekeeping

@kalverra kalverra requested review from a team as code owners November 1, 2023 20:30
Copy link
Contributor

github-actions bot commented Nov 1, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

Copy link
Contributor

github-actions bot commented Nov 1, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@@ -22,7 +22,7 @@ func TestOCRBasic(t *testing.T) {
WithGeth().
WithMockAdapter().
WithCLNodes(6).
WithFunding(big.NewFloat(.1)).
WithFunding(big.NewFloat(.01)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no need using that much cash

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalverra kalverra added this pull request to the merge queue Nov 1, 2023
Merged via the queue into develop with commit 836ab90 Nov 1, 2023
84 checks passed
@kalverra kalverra deleted the lazyFundReturn branch November 1, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants