Refactor EVM ORMs #11899
Merged
Refactor EVM ORMs #11899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
…contractkit/chainlink into BCI-2644-refactor-evm-orms
DylanTinianov
dismissed stale reviews from patrickhuie19 and jmank88
via
7004e3f
samsondav
approved these changes
Mar 14, 2024
I believe there happen to be none in this PR, but the following PRs can make use of |
jmank88
approved these changes
Mar 14, 2024
patrickhuie19
approved these changes
Mar 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Initial commit * Refactor headtracker orm * Remove unused loggers * Remove comments * Add timeout * Refactor log_poller ORM * Refactor logpoller ORM * Fix logpoller tests * Update logpoller orm * Use EventSig * update logpoller orm * Update orm.go * Update logpoller_wrapper_test.go * Update log_poller_test.go * Remove query * Remove ORM timeouts * Add context * Use testutils for context * Use testutils context * Use testutils context * Use ctx * Refactor forwarder ORM * Generate tidy * Fix logpoller mocks * Remove pg dependency * Fix mock calls * Fix mock calls * Fix mock calls * Use request context * Update context * Update contexts * Fix mock call args * Unexport orm * Fix arg name * update logpoller * unexport orm * Use query * fix tests * fix imports * Use pkgerrors * Use registry ctx * Use context * Use ctx * Use ctx * Update orm.go * Use context * Use context * Use context * Propagate context * Propagate context * Update listener_test.go * Fix context * Export DbORM struct * Update orm.go * Pass context * Pass context * Update orm.go * Use testcontext * Initialize context * Update context * Propagate context * core/services/chainlink: start using sqlutil.DB instead of pg.Q (#12386) * Check bind errors * Add close timeout * Add changeset --------- Co-authored-by: Jordan Krage <jmank88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Headtracker, Forwarder, and Logpoller ORMs to remove dependency on core/services/pg and Q type.