(feat): Combine common Transmitter into FunctionsContractTransmitter #12473
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
| @@ -71,11 +71,18 @@ func (t *transmitter) CreateEthTransaction(ctx context.Context, toAddress common | |||
| return errors.Wrap(err, "skipped OCR transmission, error getting round-robin address") | |||
| } | |||
|
|
|||
| var gasLimit uint64 | |||
| if txMeta != nil && txMeta.GasLimit != nil { | |||
There was a problem hiding this comment.
Who sets this field "txMeta.GasLimit"?
Will it be added in a later PR?
There was a problem hiding this comment.
Yes exactly. The place where Functions would use this is here:
justinkaseman
changed the title
justinkaseman
changed the title
| return oc.effectiveTransmitterAddress | ||
| } | ||
|
|
||
| func (oc *contractTransmitter) fromAddress() common.Address { |
There was a problem hiding this comment.
we don't need a helper if it's used only once
…enable product specific modifications
| contractReader contractReader | ||
| lp logpoller.LogPoller | ||
| lggr logger.Logger | ||
| reportToEvmTxMeta ReportToEthMetadata |
There was a problem hiding this comment.
We can get rid of this, it's always set to nil (= no-op). Also remove reportToEvmTxMetaNoop function.
| }, nil | ||
| } | ||
|
|
||
| func (oc *contractTransmitter) createEthTransaction(ctx context.Context, toAddress common.Address, payload []byte, txMeta *txmgr.TxMeta) error { |
There was a problem hiding this comment.
I think txMeta is always nil so we could remove it from params.
| transmittedEventSig: transmitted.ID, | ||
| lp: lp, | ||
| contractReader: caller, | ||
| lggr: lggr.Named("OCRContractTransmitter"), |
There was a problem hiding this comment.
would it help when debugging if the lggr was named: OCRFunctionsContractTransmitter?
|
No description provided.