Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vrf replay logs #12887

Merged
merged 6 commits into from
Apr 19, 2024
Merged

add vrf replay logs #12887

merged 6 commits into from
Apr 19, 2024

Conversation

jinhoonbang
Copy link
Contributor

No description provided.

@jinhoonbang jinhoonbang requested a review from a team as a code owner April 19, 2024 03:30
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

"numBlocksToReplay", numBlocksToReplay,
"replayStartBlock", replayStartBlock,
"requestTimeout", lsn.job.VRFSpec.RequestTimeout,
"finalizedLatestBlock", latestBlock.FinalizedBlockNumber,
Copy link
Contributor

@leeyikjiun leeyikjiun Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this already be added by line 123?

ll := lsn.l.With(
	"latestFinalizedBlock", latestBlock.FinalizedBlockNumber,
	"latestBlock", latestBlock.BlockNumber,
	"fromTimestamp", fromTimestamp)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. let me remove the overlapping ones.

leeyikjiun
leeyikjiun previously approved these changes Apr 19, 2024
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Comment on lines 417 to 422
case "1": // eth mainnet
case "3": // eth ropsten
case "4": // eth rinkeby
case "5": // eth goerli
case "11155111": // eth sepolia
case "1", "3", "4", "5", "11155111": // eth mainnet, robsten, rinkeby, goerli, sepolia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like the previous style of 1 chainId per line. It makes things much easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned previous style is wrong. all of these went to default:

case "1": // eth mainnet
	case "3": // eth ropsten
	case "4": // eth rinkeby
	case "5": // eth goerli

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. This style only works for languages with explicit break. Is it possible to something like below?

case
  "1", // eth mainnet
  "3", // eth ropsten
  "4", // eth rinkeby
  "5": // eth goerli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure can change it

if err != nil {
return nil, err
}
d.lggr.Debugw("Creating services for job spec", "job", string(marshalledJob))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can consider adding more tags like key hashes, max gas price, etc to make it easier to find within the logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. so key hash can be derived from "uncompressedKey" in the job spec. max gas price is already being printed elsewhere: Key = '0xd13b46290f61dB3E6638bE2746e88F0c04AB883F'\n\n[EVM.KeySpecific.GasEstimator]\nPriceMax = '200 gwei'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Anything printed can be found as a regex matching the log since tags are not indexed anyway.

@jinhoonbang jinhoonbang added this pull request to the merge queue Apr 19, 2024
Merged via the queue into develop with commit e87b83c Apr 19, 2024
105 checks passed
@jinhoonbang jinhoonbang deleted the add-vrf-replay-logs branch April 19, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants