Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reserve amount of LINK after offchain settlement #12916

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

shileiwill
Copy link
Contributor

AUTO-10222

Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@@ -875,6 +883,9 @@ contract NOPsSettlement is SetUp {
assertEq(i, index);
assertEq(0, balance);
}

// assert reserve amount of LINK is reduced by the offchain settlement amount
assertEq(registry.getReserveAmount(address(linkToken)), prevReserveBalances - totalPayments);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reserve amount of link should be 0 since it is offchain mode, users cant deposit link to registry

add test to cover the above

RyanRHall
RyanRHall previously approved these changes Apr 24, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants