Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some txdb comment typos #13059

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix some txdb comment typos #13059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-cooks-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#internal fix txdb documentation typos
8 changes: 4 additions & 4 deletions core/internal/testutils/pgtest/txdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ var _ driver.Conn = &conn{}
var _ driver.Validator = &conn{}
var _ driver.SessionResetter = &conn{}

// txDriver is an sql driver which runs on single transaction
// when the Close is called, transaction is rolled back
// txDriver is an sql driver which runs on a single transaction.
// When `Close` is called, transaction is rolled back.
type txDriver struct {
sync.Mutex
db *sql.DB
Expand Down Expand Up @@ -110,8 +110,8 @@ func (d *txDriver) Open(dsn string) (driver.Conn, error) {
return c, nil
}

// deleteConn is called by connection when it is closed
// It also auto-closes the DB when the last checked out connection is closed
// deleteConn is called by a connection when it is closed via the `close` method.
// It also auto-closes the DB when the last checked out connection is closed.
func (d *txDriver) deleteConn(c *conn) error {
// must lock here to avoid racing with Open
d.Lock()
Expand Down
Loading