[BCI-3573] - Remove dependence on FinalityDepth in EVM TXM code #13794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farber98
commented
Jul 9, 2024
Farber98
commented
Jul 11, 2024
Farber98
commented
Jul 11, 2024
silaslenihan
previously approved these changes
Aug 6, 2024
silaslenihan
approved these changes
Aug 6, 2024
amit-momin
approved these changes
Aug 7, 2024
dhaidashenko
approved these changes
Aug 7, 2024
prashantkumar1982
approved these changes
Aug 8, 2024
| return fmt.Errorf("latest finalized head is not valid") | ||
| } | ||
|
|
||
| if latestFinalizedHead.BlockNumber() > head.BlockNumber() { |
There was a problem hiding this comment.
nit: Don't think this log is needed.
The HeadTracker should never send finalzied blocks that are newer than current blocks.
This is likely a clear case of TXM panicking or throwing critical errors. But this should already been handled at HT layer.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parts of the EVM TXM code still relies on
FinalityDepthregardless if the chain is enabled to use finality tags. Through this PR we are updating the code to utilize the head tracker’s latest finalized block instead ofFinalityDepth.Acceptance Criteria
FinalityDepthshould be removed to enable the use of finality tags.FinalityDepthfrom the EVM TXM codeNotes
Ticket:
Unblocks: