BCI-3842 custom timeouts for Hedera #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dTransaction, CallContext, etc.)
dhaidashenko
changed the title
| @@ -37,3 +39,11 @@ func NewEvmClient(cfg evmconfig.NodePool, chainCfg commonclient.ChainConfig, cli | |||
| return NewChainClient(lggr, cfg.SelectionMode(), cfg.LeaseDuration(), chainCfg.NodeNoNewHeadsThreshold(), | |||
| primaries, sendonlys, chainID, chainType, clientErrors, cfg.DeathDeclarationDelay()) | |||
| } | |||
|
|
|||
| func getRPCTimeouts(chainType chaintype.ChainType) (largePayload, defaultTimeout time.Duration) { | |||
| if chaintype.ChainHedera == chainType { | |||
There was a problem hiding this comment.
Instead of this strategy, isn't it more scalable, if we create 2 configs:
under ChainClient:
[ChainClient]
RPCTimeout = 10 seconds
LargeRPCTimeout = 10 seconds
Keep these default for all chains, except we set the LargeRPCTimeout = 30 for Hedera.
In future, updating these are just config changes not needing code fixes.
dimriou
previously approved these changes
Jul 19, 2024
simsonraj
previously approved these changes
Jul 19, 2024
amit-momin
previously approved these changes
Jul 29, 2024
# Conflicts: # core/chains/evm/client/evm_client.go # core/chains/evm/client/helpers_test.go # core/chains/evm/client/rpc_client.go # core/chains/evm/client/rpc_client_test.go
dhaidashenko
dismissed stale reviews from amit-momin, simsonraj, and dimriou
via
2f84a7f
|
amit-momin
approved these changes
Jul 31, 2024
dimriou
approved these changes
Jul 31, 2024
This was referenced Jul 31, 2024
Tofel
pushed a commit
that referenced
this pull request
Aug 2, 2024
* allow to configure RPCTimeouts * Custom (30s) timeout for Hedera RPC requests with large payloads (SendTransaction, CallContext, etc.) * fix linter
This was referenced Aug 18, 2024
friedemannf
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 20, 2024
## Motivation Cherry-pick of smartcontractkit/chainlink#14021 cherry-pick of smartcontractkit/chainlink#13957 cherry-pick of smartcontractkit/chainlink#13876 cherry-pick of smartcontractkit/chainlink#13907
This was referenced Aug 21, 2024
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
* allow to configure RPCTimeouts * Custom (30s) timeout for Hedera RPC requests with large payloads (SendTransaction, CallContext, etc.) * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom 30s timeout for Hedera
Ticket
Discussion