-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntelliJ code-formatter applied to all source files; checkstyle config updates to match #97
Conversation
…s to conform with default checkstyle config
…liJ formatter (default config; 2024.1.4 Community Version) to all source files
in order to verify a totally vanilla IntelliJ code-formatter config was applied i reverted my local config to default (i didn't think i had actually changed it) and then reran the formatter and one very noticeable change appeared: wildcard imports. i always disable them because i think they're evil (anti-pattern?) when it comes to code readability. somewhat conflicted whether i should leave those in or not... :-/ (checkstyle agrees with me; this rule fires ~60 times: |
You can change this in your IntellIJ settings. I don't have a pref on this, but I know some people are anti |
…h functional changes)
I think you'll probably need to merge in the latest mainline to fix the failing tests |
AFAICT it's already merged (at least according to my local git repo which i've synced with remote). checking head commit IDs... apparently the unit-test failure was caused by an issue between Halo and the Auth-service (either the Lua script or the service started failing in new ways, returning a 500 instead of a 401 if the Auth header didn't start with "Bearer"). spoke with IainW about this last week and it sounded like it was on the radar to be fixed. rerunning failed stages now. 🤞 |
…; also added resilience4j to test dependencies
JavadocTagContinuationIndentation
build.gradle
java.header
to contain leading space indent on second line