Skip to content

Commit

Permalink
fix: move types to dependencies
Browse files Browse the repository at this point in the history
If the end user doesn't have the types installed for the libraries we require, they could potentially end up with any types. Using a wide major version to share the user's local types version if they installed them
  • Loading branch information
itsMapleLeaf committed Sep 23, 2021
1 parent 7c80c12 commit cf201da
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 69 deletions.
88 changes: 23 additions & 65 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"./utils": "./lib/utils/index.js"
},
"dependencies": {
"@types/busboy": "^0",
"@types/cookies": "^0",
"@types/node-fetch": "^2",
"@types/react": "^17",
"accepts": "^1.3.7",
"attr-accept": "^2.2.2",
"body-parser": "^1.19.0",
Expand All @@ -43,11 +47,7 @@
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.1.0",
"@testing-library/user-event": "^13.2.1",
"@types/busboy": "^0.2.4",
"@types/cookies": "^0.7.7",
"@types/jest": "^27.0.1",
"@types/node-fetch": "^2.5.12",
"@types/react": "^17.0.20",
"@typescript-eslint/eslint-plugin": "^4.31.0",
"@typescript-eslint/parser": "^4.31.0",
"babel-plugin-istanbul": "^6.0.0",
Expand Down

0 comments on commit cf201da

Please sign in to comment.