fix: make notFound() and redirect() return never
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason being is you can't actually give JSON to these types, and the page goes away when these happen, so it's logically the same as throwing It also cleans up unions; before, an empty object type could show up in the props type, but `never` "dissolves" itself in unions
smeijer
force-pushed
the
improved-release-types
branch
from
05b2126
to
9ca37c8
Compare
smeijer
changed the title
never
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason being is you can't actually give JSON to these functions, and the page goes away when these happen, so it's logically the same as throwing
It also cleans up unions; before, an empty object type could show up in the props type, but
never"dissolves" itself in unions