Skip to content

Commit

Permalink
Implemented Constants Module in GlassBR as per #134
Browse files Browse the repository at this point in the history
  • Loading branch information
@samm82
samm82 committed Jul 24, 2018
1 parent f813e3d commit db1d328
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions CaseStudies/glass/src/Python/NewImplementation/Constants.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## @file Constants.py
# @brief Library module that exports required constants.
# @date 07/24/2018

m = 7
k = 2.86e-53
E = 7.17e7
td = 3
LSF = 1
dmax = 5.0
dmin = 0.1
ARmax = 5.0
wmax = 910.0
wmin = 4.5
SDmin = 6.0
SDmax = 130.0

2 comments on commit db1d328

@samm82
Copy link
Collaborator Author

@samm82 samm82 commented on db1d328 Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smiths a) Is this the correct implementation? The old module that dealt with constants used a class, but that seems unnecessary to me.

b) Should I comment every line with what the variable is when that information is captured in the SRS, MIS, etc.?

@smiths
Copy link
Owner

@smiths smiths commented on db1d328 Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. A class is the wrong implementation for something so simple. Your implementation follows our current design.

No, you don't need to comment every line. When Drasil generates code, we could consider turning this level of commenting on or off, but it is far too difficult to maintain by hand.

Please sign in to comment.