-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hardcoded References in SRS #31
Comments
The original text was wrong. I've fixed it in 65bba6a. The original intention would have been to use citations, but for some reason they were hard-coded into the original. @samm82, can you check whether this same mistake was propagated to Drasil? If so, can you fix it there as well. When you have had a chance to look into the Drasil status of this issue, please close this issue. I am also going to create another issue related to this because when I looked at the bib file I found that the existing entries are not proper. |
My original intent with this issue was that there wasn't a section referenced after "Section.", but your change is a better fix - I found more examples of hardcoded references while looking through Drasil - I'll look for them in caseStudies, but I'm kind of stuck on the |
This comment has been minimized.
This comment has been minimized.
take a annealedGl = cc annealedGlass
(foldlSent [S "A flat, monolithic, glass lite which has uniform thickness where the",
S "residual surface stresses are almost zero, as defined in", cite gbRefDB astm2016) If so, this should probably be a separate issue, as it will be quite large/time intensive. @JacquesCarette @szymczdm @smiths |
That would be what |
@samm82, maybe you should close this issue here, since the original problem with the manual case study has been fixed. You can then create another issue in the Drasil repo if there are challenges for implementation in the generated version. |
Lines 288-289 of glassbr_srs.tex are missing a reference to another section: "...standards for constructions using glass from {[}4-6{]} in
Section. The users of GlassBR can have a lower level of..."
TODO
The text was updated successfully, but these errors were encountered: