Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hardcoded References in SRS #31

Closed
1 of 7 tasks
samm82 opened this issue May 2, 2018 · 7 comments
Closed
1 of 7 tasks

Fix Hardcoded References in SRS #31

samm82 opened this issue May 2, 2018 · 7 comments
Assignees
Labels

Comments

@samm82
Copy link
Collaborator

samm82 commented May 2, 2018

Lines 288-289 of glassbr_srs.tex are missing a reference to another section: "...standards for constructions using glass from {[}4-6{]} in
Section. The users of GlassBR can have a lower level of..."

TODO

  • Fix in caseStudies
  • Fix in Drasil
    • Characteristics of Intended Reader
    • Terminology and Definitions
      • Glass Type
      • Load
    • Calculation of Capacity IM
@samm82 samm82 changed the title Missing Section Number in glassbr_srs GlassBR - Missing Section Number in SRS May 3, 2018
@samm82 samm82 added the GlassBR label Jun 5, 2018
@samm82 samm82 changed the title GlassBR - Missing Section Number in SRS Missing Section Number in SRS Jun 5, 2018
@smiths
Copy link
Owner

smiths commented Jun 26, 2018

The original text was wrong. I've fixed it in 65bba6a. The original intention would have been to use citations, but for some reason they were hard-coded into the original. @samm82, can you check whether this same mistake was propagated to Drasil? If so, can you fix it there as well.

When you have had a chance to look into the Drasil status of this issue, please close this issue.

I am also going to create another issue related to this because when I looked at the bib file I found that the existing entries are not proper.

@samm82 samm82 self-assigned this Jun 26, 2018
@samm82 samm82 changed the title Missing Section Number in SRS Fix Hardcoded References in SRS Jun 27, 2018
@samm82
Copy link
Collaborator Author

samm82 commented Jun 27, 2018

My original intent with this issue was that there wasn't a section referenced after "Section.", but your change is a better fix - I found more examples of hardcoded references while looking through Drasil - I'll look for them in caseStudies, but I'm kind of stuck on the ! Undefined control sequence. error in \tableofcontents in the build version of GlassBR as described in JacquesCarette/Drasil#701, as I can't really verify my changes.

@samm82

This comment has been minimized.

@samm82
Copy link
Collaborator Author

samm82 commented Jun 29, 2018

Should this:
https://github.com/JacquesCarette/Drasil/blob/0324a081966f5555ca8bcd457d88ec287b8f0540/code/Language/Drasil/Chunk/Concept.hs#L41-L43

take a Sentence instead of a String? Then foldlSent could be used like this:

annealedGl    = cc annealedGlass
  (foldlSent [S "A flat, monolithic, glass lite which has uniform thickness where the",
    S "residual surface stresses are almost zero, as defined in", cite gbRefDB astm2016)

instead of:
https://github.com/JacquesCarette/Drasil/blob/0324a081966f5555ca8bcd457d88ec287b8f0540/code/Example/Drasil/GlassBR/Unitals.hs#L257-L259

If so, this should probably be a separate issue, as it will be quite large/time intensive. @JacquesCarette @szymczdm @smiths

@JacquesCarette
Copy link
Collaborator

That would be what cc' is for.

@smiths
Copy link
Owner

smiths commented Jul 1, 2018

@samm82, maybe you should close this issue here, since the original problem with the manual case study has been fixed. You can then create another issue in the Drasil repo if there are challenges for implementation in the generated version.

@samm82
Copy link
Collaborator Author

samm82 commented Jul 3, 2018

@samm82 samm82 closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants