Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GlassBR bib References #104

Closed
smiths opened this issue Jun 26, 2018 · 3 comments
Closed

Fix GlassBR bib References #104

smiths opened this issue Jun 26, 2018 · 3 comments
Assignees
@samm82

Comments

@smiths
Copy link
Owner

smiths commented Jun 26, 2018

While working on #31, I found that the entries in the bib file for the GlassBR SRS are lacking. Can you please fix the following references: C1036, C1048, C1172, D4065, E631, and E1300. The revised references should have a simple author field. ASTM is fine as the author. If the year is missing, the year should be added. The citation names should also be changed to match the author year style. That is, ASTM1999, or whatever.
samm82 added a commit that referenced this issue Jun 27, 2018
@samm82
Fixed references: C1036, C1048, C1172 (#104)
7d5d9fc
samm82 added a commit that referenced this issue Jun 27, 2018
@samm82
Fixed references: D4065, E631, E1300 (#104)
b1e0c11
@samm82
Copy link
Collaborator

samm82 commented Jun 27, 2018

Do you want the references in a specific order in the .bib file? Should they stay in the original order or be alphabetized? @smiths

samm82 added a commit that referenced this issue Jun 27, 2018
@samm82
Updated glassbr_srs.pdf and .tex (#104)
9337023
@samm82
Copy link
Collaborator

samm82 commented Jun 27, 2018

Unless you want me to change ordering, I think this issue is closed. @smiths

samm82 added a commit that referenced this issue Jun 27, 2018
@samm82
Reflected change made in 65bba6a with new citation names (#104)
da920b0
@smiths
Copy link
Owner Author

smiths commented Jun 27, 2018

Looks good. Yes, we can close this issue.

@smiths smiths closed this as completed Jun 27, 2018
@samm82 samm82 mentioned this issue Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samm82 samm82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smiths @samm82