Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolarHeatingWaterOnly_SRS: Clarity Issue #59

Open
elwazana opened this issue May 3, 2018 · 3 comments
Open

SolarHeatingWaterOnly_SRS: Clarity Issue #59

elwazana opened this issue May 3, 2018 · 3 comments
Assignees

Comments

@elwazana
Copy link
Collaborator

elwazana commented May 3, 2018

In section 6, LC3 mentions the charging and discharging of the tank. However, it may make the sentence clearer by mentioning that this is in reference to the temperature of the tank, rather than leave it as ambiguous "charging/discharging".

@smiths smiths self-assigned this May 3, 2018
@smiths
Copy link
Owner

smiths commented May 3, 2018

@elwazana can you pull the text from the original and reproduce it in your issue? It will make it much faster to review. You can also assign issue like this to me.

@elwazana
Copy link
Collaborator Author

elwazana commented May 3, 2018

LC3: A9 - The model currently only accounts for charging of the tank. A more complete
model would also account for discharging of the tank.

@smiths
Copy link
Owner

smiths commented Jun 11, 2018

I guess it wasn't faster (in this case) to put the text together with the issue. 😄

You are correct that the charging terminology may not be familiar to all of the readers. How about:

"LC3: A9 - The model currently only accounts for heating of the tank. That is, increasing the temperature of the water and the PCM to match the temperature of the coil. A more complete model would also account for cooling of the tank."

Please also make this change in the Drasil code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants