Change Add to Whitelist Button to Whitelist Toggle Button #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context menu, if the user clicks the whitelist button and the domain is already in the whitelist, it will remove it. This (along with changing the name of the context menu button) will provide a much easier and much faster method of removing websites from the whitelist, a feature that at least I would use a lot (I often used that feature in another image blocker), and I'm sure others would benefit from it as well. PS. This is my first time committing to a GitHub repository and my first time working on an extension, so please let me know if I'm doing anything wrong. I've only tested it in Chromium on Linux, but it's simple enough that it should work on other browsers/systems.
I changed the name of the whitelist button in the context menu to make it clearer that it would toggle the tab's domain in the whitelist. I don't know if there's a way to have it say "Add tab to Whitelist" if it's not already in the whitelist and "Remove tab from Whitelist" if it is, but if you know of a way to do that and you have the time, that would probably be ideal.
Add Ability to Remove from Whitelist in Context Menu
Update Whitelist Name to Reflect Changes in background.js
Change default behavior of clicking on extension from temporarily disable to whitelist.
Single Click Whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it easier to remove websites from the white list but making the "Whitelist this tab's domain" button in the context menu into a button adds the website to the whitelist if it's not already in the whitelist and removes it if it is. I've also changed the name of the button to reflect that (Add/Remove tab from Whitelist). As this is my first time doing anything with browser extensions, I don't know if there's a way to make the name of the button be "Add tab to Whitelist" if it's not already in the whitelist and "Remove tab from Whitelist" if it is, but if you know of a way to do that and you have the time, that would probably be ideal.