Add Sender::broadcast_blocking and Receiver::recv_blocking
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support blocking broadcast and receive using the `wait()` function from the `event-listener` crate Fixes smol-rs#41
hozan23
force-pushed
the
add_recv_broadcast_blocking
branch
from
d54b7e3
to
56406d8
Compare
|
LGTM but I'd want @notgull's opinion too. |
|
seems @notgull is busy these days. I'll merge this. We can always revert if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support blocking broadcast and receive using the
wait()function from theevent-listenercrateI'm unsure about calling
wait()onrecv_direct()andbroadcast_direct()methods. I'm open to making adjustments.Fixes #41