Replace some async blocks with manual futures #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
taiki-e
reviewed
Dec 25, 2022
src/lib.rs
Outdated
Comment on lines
18
to
22
| pub use barrier::{Barrier, BarrierWaitResult}; | ||
| pub use mutex::{Mutex, MutexGuard, MutexGuardArc}; | ||
| pub use mutex::{Lock, LockArc, Mutex, MutexGuard, MutexGuardArc}; | ||
| pub use once_cell::OnceCell; | ||
| pub use rwlock::{RwLock, RwLockReadGuard, RwLockUpgradableReadGuard, RwLockWriteGuard}; | ||
| pub use semaphore::{Semaphore, SemaphoreGuard, SemaphoreGuardArc}; | ||
| pub use semaphore::{Acquire, AcquireArc, Semaphore, SemaphoreGuard, SemaphoreGuardArc}; |
There was a problem hiding this comment.
Why are the futures from rwlock and barrier not exported?
That said, exporting everything might make the documentation less readable... (FYI, tokio has modules for named futures. futures exposes each of the sub-modules or gives a verbose name.)
There was a problem hiding this comment.
I added a futures module that contains all of the exported named futures.
taiki-e
approved these changes
Dec 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to resolve #4 by adding manually-implemented futures to
Mutex,RwLock,BarrierandSemaphore, similar to smol-rs/async-channel#33. This aim of this PR is to improve semantics for whenpollis the only means available to poll a future. The main downside is that is replaces the elegantasyncblocks with some more garish manual futures, but I tried to keep the semantics and ordering of logic the same throughout.I avoided adding implementations for
OnceCell, since with the closures and self-referential ideas it's not possible to implement without either a significant amount of hard-to-checkunsafecode or overextensive heap allocation.Closes #4
Closes #5