Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to event-listener v3.0.0 #43

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Bump to event-listener v3.0.0 #43

merged 2 commits into from
Sep 17, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented May 20, 2023

Testing to make sure that event-listener v3.0.0 actually works before we release smol-rs/event-listener#58

Needs smol-rs/event-listener#60

@notgull
Copy link
Member Author

notgull commented Aug 8, 2023

I've modified the futures to be !Unpin to save a heap allocation, so this is now a breaking change.

taiki-e
taiki-e reviewed Aug 9, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@taiki-e

This comment was marked as resolved.

Sign in to view
@notgull notgull mentioned this pull request Sep 11, 2023
Closed
@notgull notgull marked this pull request as ready for review September 11, 2023 15:49
@notgull
Copy link
Member Author

notgull commented Sep 11, 2023

event-listener v3 and event-listener-strategy v0.1 are now released, so we are fine to review this PR.

taiki-e
taiki-e reviewed Sep 12, 2023
View reviewed changes
src/semaphore.rs Outdated Show resolved Hide resolved
@notgull notgull mentioned this pull request Sep 13, 2023
Closed
taiki-e
taiki-e reviewed Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you update the CI config to test cases where the default features are disabled?

src/mutex.rs Show resolved Hide resolved
notgull and others added 2 commits September 17, 2023 07:57
@notgull
Bump to event-listener v3.0.0
8f8b4fe 
The new version of event-listener comes with several new changes, including less
heap allocation and no_std support.

This is a breaking change as it makes a handful of futures !Unpin.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Add a default "std" feature for no_std usage
3a82590 
This is a breaking change for no-default-features users.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull merged commit c788964 into master Sep 17, 2023
8 checks passed
@notgull notgull deleted the notgull/evl-v3.0.0 branch September 17, 2023 15:07
@notgull notgull mentioned this pull request Sep 25, 2023
Merged
@mnmaita mnmaita mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @taiki-e