Add Semaphore::add_permits()
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
May 26, 2023
|
Test added |
notgull
reviewed
May 27, 2023
There was a problem hiding this comment.
Looks good to me, but I'd prefer to test the edge case.
Could you add a test where you have an Acquire future that tries to acquire a permit on a zero-permit Semaphore? It should return Pending (use future::poll_once() to test this). Then, once the add_permits(1) function is called, it should resolve to Ready. It should also test using another Acquire that should not be woken up by this call.
Jules-Bertholet
force-pushed
the
semaphore-add-permits
branch
from
64d7386
to
60d067a
Compare
|
Test added |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows increasing the permit count of the semaphore after creation.
Fixes #22