-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcards missing from comments #85
Comments
Hello Mitchell, yes, indeed. We could do that. At first I was a bit hesitant - not knowing what the buffer size for SLURM strings is. And I bloody well do not want to break anybodies batch system. Yet, SLURM matured over time and as far as I can tell (please, anyone correct me, if I am wrong!), there is no such string limit for comments of job names. And my own tinkering with hello world scripts confirms this. So, I will - as time permits - draft a PR. Cheers |
Great! Made a small PR ^. Hope it helps. |
closed in #88. |
Ah, you are faster than me - got pretty busy. Anyway, this issues does not go without a "Thank you!". |
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.5...v0.5.0) (2024-05-06) ### Features * wildcards in comment string [#85](#85) ([#88](#88)) ([730cac0](730cac0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hello,
I was very excited to see in the patch notes the inclusion of wildcards in the slurm comment and log path.
So I updated the plugin to get those features, and while I see wildcards in the log path (e.g.
.snakemake/slurm_logs/rule_fire/PS00474_HG02630_1_JAHAOQ010000001.1/18033650.log
), I still don't see them in the SLURM comment field, just the rule name (e.g.fire
). Any ideas?Thanks in advance,
Mitchell
The text was updated successfully, but these errors were encountered: