Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix and catch more wallet rejection error #115

Merged
merged 5 commits into from
Aug 1, 2024
Merged

fix: fix and catch more wallet rejection error #115

merged 5 commits into from
Aug 1, 2024
+4 −6

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 1, 2024

This PR fix

  1. fix 2 invalid comparisons
  2. catch and ignore the -32002 error on the second try (fixing issue pointed out in chore: update lock package sx-monorepo#571 (comment))
  3. remove the console.log, as they're already done by the injected wallet, resulting of error logging twice

@wa0x6e wa0x6e requested a review from ChaituVR August 1, 2024 11:10
ChaituVR
ChaituVR approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit bf02d49 into master Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR