Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade walletlink SDK #120

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: upgrade walletlink SDK #120

merged 1 commit into from
Sep 18, 2024

Conversation

bonustrack
Copy link
Member

@bonustrack bonustrack commented Aug 28, 2024

Closes https://github.com/snapshot-labs/workflow/issues/138

To test it you'll need to add this in the UI, otherwise it will fail with the error Buffer is not defined. We will need to check if this impact the UI bundle size.

import { Buffer } from 'buffer';
...
window.Buffer = Buffer as any;

@ChaituVR ChaituVR self-requested a review August 28, 2024 14:21
@ChaituVR
Copy link
Member

ChaituVR commented Aug 29, 2024

This seem to be working and bundle size doesn't change

But when I sign a message I get signature validation failed and also close method is deprecated so I am unable to logout right now (on v1), Figuring out solutions for these

@ChaituVR
Copy link
Member

To test it you'll need to add this in the UI, otherwise it will fail with the error Buffer is not defined. We will need to check if this impact the UI bundle size.

I don't see any error with buffer weirdly 🤔

@ChaituVR
Copy link
Member

Looks like we already import Buffer and assign it to window

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 03164f5 into master Sep 18, 2024
1 check passed
@ChaituVR ChaituVR deleted the fabien/walletlink branch September 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants