Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better markdown code block UI #274

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: better markdown code block UI #274

merged 1 commit into from
Apr 15, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Apr 13, 2024

Summary

Closes: #272

Add title bar to markdown code block to show language if available, and copy button

Copy button will now transform to check icon for 1s on click, instead of triggering flash notification

Screenshot 2024-04-14 at 03 01 56

How to test

  1. Go to any proposal with code block, e.g. http://localhost:8080/#/s:test.wa0x6e.eth/proposal/0xf56083e1fcbdc5c9ad15d9e91f67a72b817bdf83f1589af8db20e27385db95e1

@wa0x6e wa0x6e requested a review from bonustrack April 13, 2024 23:04
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 5591831 into master Apr 15, 2024
3 checks passed
@Sekhmet Sekhmet deleted the fix-272 branch April 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: code markdown style
3 participants