feat: add single choice and approval voting type

[wa0x6e]

Summary

Closes: #15

Add support for approval voting

Changes

• changes some typing to support number[] as choices type
• edited UI to support selecting multiple choices

How to test

1. You can test with http://localhost:8080/#/s-tn:wan-test.eth (wallet private key in sx.js test/integration/offchain/index.test.ts)
2. There's 2 proposals with each voting type for testing

[samuveth]

After I voted it shows a message You have already votes on this proposal but I see zero votes and no current results until I refresh the page. Shouldn't it refresh the results after I voted?

[Sekhmet]

Shouldn't it refresh the results after I voted?

For SX it will take some time before vote is indexed so we do not refresh (it can take few minutes sometimes for indexer to see transaction). Maybe it makes more sense here but it shouldn’t be part of this PR

[wa0x6e]

I agree with it not being part of this PR.

We have a pendingTransaction store on the UI, which receive the tx after a vote. What I would to would be to add some kind of watcher there, and refresh the related UI store (proposal, space, etc ...) when tx pass, then all dependent component will refresh by themselves.

[Sekhmet]

Other than this one small change all looks good to me, great job!

[Sekhmet]

Suggested change

	(e: 'handleVoteClick', value: Choice);
	(e: 'voteClick', value: Choice);

We tend to call handler function with handle prefix, but emit names don't have that prefix.

[wa0x6e]

Do we need to keep the Click suffix ? If not, it will look better like

@vote="handleVoteClick"

[wa0x6e]

Also, we have a handleVoteClick function in 2 places: ProposalListsItem.vue and Proposal.vue.

Wouldn't it be cleaner if we move this inside ProposalVote ?

[Sekhmet]

Indeed vote makes more sense as I took better look at the usage.

Also, we have a handleVoteClick function in 2 places: ProposalListsItem.vue and Proposal.vue.

I don't think we can as it's just wrapper that gets actual buttons from the outside.

[wa0x6e]

In that case, we could move everything inside ProposalVote, and just call it with

<ProposalVote v-if="proposal" :proposal="proposal" show-type="['basic']"> // To show only basic type
<ProposalVote v-if="proposal" :proposal="proposal"> // To show everything

[Sekhmet]

Also CI is failing.

[wa0x6e]

Also CI is failing.

This one is due to a typing issue, which I am not able to resolve. If you have some advices

[Sekhmet]

diff --git a/packages/sx.js/src/clients/offchain/types.ts b/packages/sx.js/src/clients/offchain/types.ts
index 01e9ab22..87dd8e02 100644
--- a/packages/sx.js/src/clients/offchain/types.ts
+++ b/packages/sx.js/src/clients/offchain/types.ts
@@ -1,10 +1,6 @@
 import type { TypedDataDomain, TypedDataField } from '@ethersproject/abstract-signer';
 
-enum Choice {
-  Against = 2,
-  For = 1,
-  Abstain = 3
-}
+type Choice = number | number[];
 
 export type SignatureData = {
   address: string;

[wa0x6e]

Still no luck, for some reasons, it's using the Vote type from src/types and not from offchain

[Sekhmet]

@wa0x6e it will work if you run yarn build first, I will update our scripts so it will rebuild sx.js before running yarn typecheck.

[Sekhmet]

Fixed typecheck script on master: c76f035

[Sekhmet]

tACK