Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test coverage #114

Closed
plastikfan opened this issue Aug 9, 2024 · 3 comments · Fixed by #181
Closed

improve test coverage #114

plastikfan opened this issue Aug 9, 2024 · 3 comments · Fixed by #181
Assignees
@plastikfan
Labels
test Automated testing

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Aug 9, 2024 •
edited
Loading

need to get this up to 90%+ range

See:
@plastikfan plastikfan added the test Automated testing label Aug 9, 2024
@plastikfan plastikfan self-assigned this Aug 9, 2024
@plastikfan
Copy link
Contributor Author

  • might need to redesign the tests in navigator-folders-with-files_test, because currently it only tests for glob child filter so the other child filter types are not covered.

plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
7509be6
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
7fbb34f
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
11e46fb
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
317bc99
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
48e4ec0
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
13d01c7
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
2ea0087
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
018dff1
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
c1878fc
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
4b69eee
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
887bca0
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
814cf04
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
17085e4
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
6fced4e
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
444e008
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
09d24b0
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
d71e0d8
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
4163148
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
d25ecf5
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
d2d135c
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
f42e049
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
4608b93
plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
9c95786
@plastikfan
Copy link
Contributor Author

link to issue raised on ginkgo for running coverage in ci: 'no such file or directory’ running coverage

plastikfan added a commit that referenced this issue Sep 9, 2024
@plastikfan
test: improve test coverage (#114)
7a47e79
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
f0fd771
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
64f4a76
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
6d50b6d
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
f54e5ab
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
26ba527
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
bfee91b
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
d536f4d
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
a7cdc68
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
fda79ea
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
1def70a
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
51ec498
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
56064f2
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
e56a255
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
c9929b0
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
b42a062
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
7e1904a
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
5ef67fe
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
f252cc8
@plastikfan
Copy link
Contributor Author

plastikfan commented Sep 10, 2024 •
edited
Loading

The problem of not being able to generate code coverage was addressed by this issue I raised in ginkgo: issue 1404:coverprofile not creating output file in the location specified

plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
80dfd56
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
3085103
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
a1b0abf
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
ed980ce
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
7f5923c
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
1e5f616
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
b529ef8
@plastikfan plastikfan linked a pull request Sep 10, 2024 that will close this issue
test: improve test coverage (#114) #181
Merged
plastikfan added a commit that referenced this issue Sep 10, 2024
@plastikfan
test: improve test coverage (#114)
5e3d7ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
test Automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve test coverage (#114) snivilised/traverse
1 participant
@plastikfan