Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curl dependency #153

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

ivanychev
Copy link
Contributor

@ivanychev ivanychev commented Jul 19, 2024

Thanks for the amazing GitHub Action!

This PR removes curl usage from the script and replaces it with python3. Many hosted GitHub Action runners don't have curl by default, so they are required to install it before using this action. This PR ensures that the installation of curl is not needed.

@sondrelg
Copy link
Member

Cool. I agree, cutting dependencies is good, but would you mind showing me documentation that python3 always needs to be present in self-hosted runners? Otherwise, aren't we just substituting one dependency for another?

@ivanychev
Copy link
Contributor Author

Hey @sondrelg! The script already relies on Python 3 to install poetry (search for python3 in the file). The script uses the “official” way of installing poetry: (https://python-poetry.org/docs/#installing-with-the-official-installer) — it downloads Python script and executes it.

@sondrelg
Copy link
Member

Hehe yeah good point. I'll try to get this reviewed properly this week 👍

@sondrelg sondrelg merged commit 0a8188c into snok:main Jul 23, 2024
50 checks passed
@sondrelg
Copy link
Member

Thanks @ivanychev. This looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants