Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Socket.request writable to allow setting it to null as suggested in the documentation #697

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jonathanperret
Copy link
Contributor

Fixes #696.

I would have added a test that confirms the issue is fixed, but since this is a TypeScript-only issue and the tests are not yet converted to TypeScript it seems difficult.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

@darrachequesne darrachequesne merged commit 0efa04b into socketio:main Feb 23, 2024
2 checks passed
@darrachequesne
Copy link
Member

@jonathanperret thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set socket.request to null because the property is read-only
2 participants