add biz jar url in biz module #928
Conversation
WalkthroughThe recent changes enhance the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
============================================
- Coverage 78.70% 78.56% -0.14%
- Complexity 836 850 +14
============================================
Files 164 167 +3
Lines 6796 6873 +77
Branches 1009 1016 +7
============================================
+ Hits 5349 5400 +51
- Misses 923 946 +23
- Partials 524 527 +3 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (5 hunks)
- sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizFactoryServiceImpl.java (1 hunks)
- sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/BizInfo.java (1 hunks)
- sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/src/test/java/com/alipay/sofa/ark/test/MultiArkBootRunnerTest.java (2 hunks)
Files skipped from review due to trivial changes (1)
- sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/BizInfo.java
Additional comments not posted (3)
sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/src/test/java/com/alipay/sofa/ark/test/MultiArkBootRunnerTest.java (1)
32-32: Update toArkBootEmbedRunnerapproved. Ensure compatibility with existing tests.sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizFactoryServiceImpl.java (1)
92-92: Addition ofsetBizUrlincreateBizmethod approved. Verify correct URL setting across archive types.Verification successful
The verification process did not reveal any direct error handling or logging mechanisms related to
bizUrl. ThesetBizUrlmethod is used correctly in theBizFactoryServiceImplclass and is defined in theBizModelclass. The usage ofbizUrlin test cases and constants does not indicate any issues.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `setBizUrl` correctly sets URLs across different archive types. # Test: Search for incorrect URL settings in logs. Expect: No errors related to URLs. rg --type java $'setBizUrl' --exec grep 'Error'Length of output: 453
Script:
#!/bin/bash # Description: Verify that `setBizUrl` correctly sets URLs across different archive types. # Search for occurrences of `setBizUrl` in the codebase and inspect the context for error handling or logging. rg --type java 'setBizUrl' -A 5 -B 5Length of output: 3466
Script:
#!/bin/bash # Description: Verify that `setBizUrl` correctly sets URLs and check for any error handling or logging related to `bizUrl`. # Search for occurrences of `bizUrl` in the codebase and inspect the context for error handling or logging. rg --type java 'bizUrl' -A 5 -B 5Length of output: 45342
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (1)
80-80: Addition ofbizUrlfield and related methods inBizModelapproved. Verify correct usage ofbizUrlin the application.Also applies to: 143-148, 246-248
Verification successful
The
bizUrlfield is used in the following main files:
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.javasofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizCommandProvider.javaLet's review the usage in these files to ensure it is correct.
BizModel.java
- The
bizUrlfield is declared.- It is set using
this.bizUrl = url;.- It is returned using
return bizUrl;.- It is included in the
toStringmethod.
BizCommandProvider.java
- The
bizUrlis mentioned in a command description string.Based on the review, the usage of
bizUrlin the main files appears to be correct and consistent with the intended functionality.Conclusion
The addition of the
bizUrlfield and its usage in the application is correct.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `bizUrl` is being used correctly in the application. # Test: Search for incorrect usage of `bizUrl`. Expect: No errors related to `bizUrl`. rg --type java $'bizUrl' --exec grep 'Error'Length of output: 450
Script:
#!/bin/bash # Description: Verify that `bizUrl` is being used correctly in the application. # Test: Search for the usage of `bizUrl` in the codebase. rg --type java 'bizUrl'Length of output: 6778
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (4 hunks)
- sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizFactoryServiceImpl.java (1 hunks)
- sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/BizInfo.java (1 hunks)
- sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/src/test/java/com/alipay/sofa/ark/test/MultiArkBootRunnerTest.java (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizFactoryServiceImpl.java
- sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/BizInfo.java
- sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/src/test/java/com/alipay/sofa/ark/test/MultiArkBootRunnerTest.java
Additional Context Used
GitHub Check Runs (1)
codecov/patch success (1)
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java: [warning] 247-247: sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java#L247
Added line #L247 was not covered by tests
Additional comments not posted (3)
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (3)
80-81: Added a new fieldbizUrlto store the business URL.
143-146: Added a setter methodsetBizUrlfor thebizUrlfield. This method follows the fluent interface pattern, allowing method chaining which is consistent with other setter methods in this class.
427-429: Updated thetoStringmethod to include thebizUrlfield. This change ensures that the business URL is part of the object's string representation, which can be useful for logging and debugging purposes.
| @Override | ||
| public URL getBizUrl() { | ||
| return bizUrl; | ||
| } |
There was a problem hiding this comment.
Tip
Codebase Verification
- No test cases found for the
getBizUrlmethod.
There are no test cases covering the getBizUrl method in the codebase. It is recommended to add unit tests to ensure this method's functionality is verified.
Analysis chain
Added a getter method getBizUrl for the bizUrl field. This method is necessary for accessing the bizUrl outside of this class.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the new getter method `getBizUrl` is covered by unit tests.
# Test: Search for the test coverage of `getBizUrl`. Expect: At least one test case covering this method.
rg --type java $'public void testGetBizUrl\(\)'
Length of output: 48
Script:
#!/bin/bash
# Description: Search for references to the `getBizUrl` method in the test files to check for indirect test coverage.
# Test: Search for any references to `getBizUrl` in the test files.
rg --type java 'getBizUrl'
Length of output: 258
(cherry picked from commit e1f5872)
* 优化排包配置 (#918) * 优化显示 * fix as bizStateRecords * 更新显示 * 优化自动排包配置 * 更新排包描述 --------- Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit 5a13e01) * runtime中静态合并部署时多模块并行执行createTempDir时异常 (#911) Co-authored-by: jiyunfei <jiyunfei@come-future.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit 67a0bdf) * add string contains (#926) (cherry picked from commit 07009d7) * fix ReactiveWebServerFactoryAutoConfiguration not support sprintboot 1.x (#927) (cherry picked from commit 41d3cda) * add biz jar url in biz module (#928) (cherry picked from commit e1f5872) * update netty version (#931) * update netty version * fix version netty --------- Co-authored-by: tangjiafu <tangjiafu@kuaishou.com> Co-authored-by: leojames <leojames.googol@gmail.com> (cherry picked from commit fb233cf) * update version to 3.0.6-SNAPSHOT --------- Co-authored-by: Lipeng <44571204+gaosaroma@users.noreply.github.com> Co-authored-by: FFF <31267018+1034323716@users.noreply.github.com> Co-authored-by: Laglangyue <35491928+laglangyue@users.noreply.github.com>
(cherry picked from commit e1f5872)
* 优化排包配置 (#918) * 优化显示 * fix as bizStateRecords * 更新显示 * 优化自动排包配置 * 更新排包描述 --------- Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit 5a13e01) * runtime中静态合并部署时多模块并行执行createTempDir时异常 (#911) Co-authored-by: jiyunfei <jiyunfei@come-future.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit 67a0bdf) * add string contains (#926) (cherry picked from commit 07009d7) * fix ReactiveWebServerFactoryAutoConfiguration not support sprintboot 1.x (#927) (cherry picked from commit 41d3cda) * add biz jar url in biz module (#928) (cherry picked from commit e1f5872) * update netty version (#931) * update netty version * fix version netty --------- Co-authored-by: tangjiafu <tangjiafu@kuaishou.com> Co-authored-by: leojames <leojames.googol@gmail.com> (cherry picked from commit fb233cf) * update version to 3.1.4-SNAPSHOT * fix multi ark boot runner test --------- Co-authored-by: Lipeng <44571204+gaosaroma@users.noreply.github.com> Co-authored-by: FFF <31267018+1034323716@users.noreply.github.com> Co-authored-by: Laglangyue <35491928+laglangyue@users.noreply.github.com>
Summary by CodeRabbit
New Features
Improvements
BizModelclass to include the business URL in its string representation for better debugging and logging.Testing
ArkBootEmbedRunnerfor improved test execution.