Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerOptionsBuilder::privileged() #149

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

imp
Copy link
Contributor

@imp imp commented Jan 7, 2019

This adds new ContainerOptionsBuilder method privileged() to enable running privileged docker containers. I think it should be mentioned in CHANGELOG.md. Also, this could be potentially an incompatible change, since API addition is considered an incompatible change in semver universe.

The implementation is pretty straightforward, - the privileged field is already present in HostConfig, so there is only a new builder option to set the field to a required value.

As a side note - I have followed the precedence set by auto_remove() that gets a boolean argument. However, if I was to implement it from the scratch I'd choose to drop the boolean argument completely (similarly to the docker command line - you only mention it if you need it).

Fixes #148

@softprops
Copy link
Owner

@imp this branch seems to have a conflict with master. if you pull merge in latest Ill merge here

@imp
Copy link
Contributor Author

imp commented Jan 11, 2019

@softprops rebased

@softprops softprops merged commit 31a913b into softprops:master Jan 21, 2019
@softprops
Copy link
Owner

published a new release including this pr https://github.com/softprops/shiplift/blob/master/CHANGELOG.md#050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating privileged docker containers
2 participants