forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/playground use onyx #81
Merged
blazejkustra
merged 10,000 commits into
software-mansion-labs:ts-migration/compose
from
fabioh8010:feature/playground-use-onyx
Mar 7, 2024
Merged
Feature/playground use onyx #81
blazejkustra
merged 10,000 commits into
software-mansion-labs:ts-migration/compose
from
fabioh8010:feature/playground-use-onyx
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_page feat: category settings page
…id/fix-video-sharing Fix sharing video player from chat to attachment modal
…hPage fix/revert back correct DateOfBirth page
…ions Feature/35713 bulk actions
# Conflicts: # src/libs/E2E/client.ts
Fix: User navigates to many pages when quickly press them in ProfilePage
in recent destinations, bold description if title is not available
Update Set-Up-the-Card-for-Your-Company.md
…Script [TS Migration] Migrate Image to TypeScript
…MockToTypeScript [No QA] [TS migration] Migrate 'react-native.js' mock to TypeScript
Back button in SAML page doesn't work to go back to log in page
…oom_applied_after_zooming_out fix: resetting pinchScale.value to 1 when double tap performed
…wn-to-close-gesture fix: no action after swipe down to close action
Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>
…s-migration/fs-mock
[CP staging] Fix join button displayed in group chat
…ton-gray [CP Staging] Expensify#37711 drop down button uses success design on confirmation list
…ection-left-modal fix: gesture direction for left modal stack
Hover menu is not dismissed after opening emoji picker
…-required-fields Fix able to confirm split a scan request in policy expense chat even though the merchant is empty
…tching-between-tabs Fix - Mark the chat as "read" immediately upon switching to the tab
…image-blink Fix receipt image blink when opening it the first time
…s-mock [No QA] [TS migration] Migrate 'fs.js' mock to TypeScript
…o-image-manipulator [New architecture] Replace `@oguzhnatly/react-native-image-manipulator` with `expo-image-manipulator`
…name-formula Fix optimistic report amount in title
Fix: Emoji picker - Highlight is removed from emoji when scrolling up with up key
blazejkustra
merged commit Mar 7, 2024
2193a07
into
software-mansion-labs:ts-migration/compose
6 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop