Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused devDependencies #1847

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Remove unused devDependencies #1847

merged 6 commits into from
Jan 27, 2022

Conversation

jakub-gonet
Copy link
Member

Description

Removed some unused dev packages.

Test plan

Ran example app on iOS.

@jakub-gonet
Cleanup packages
75c2116 
- Removed unused eslint configs
- Removed flow support
- Replaced jest-react-native with react-native preset
@jakub-gonet
Update Podfile.lock
5582b8a
@jakub-gonet jakub-gonet changed the title Remove unused devPackages Remove unused devDependencies Jan 26, 2022
@jakub-gonet
Restore eslint-config-satya164
0f599d3 
It's used in eslintrc config
j-piasecki
j-piasecki reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check failing suggests that some of them weren't unused. Keeping eslint-import-resolver-babel-module and adding eslint-plugin-jest seems to be enough to make it work.

@jakub-gonet jakub-gonet merged commit dfd4c5a into main Jan 27, 2022
@jakub-gonet jakub-gonet deleted the jgonet/cleanup-packages branch January 27, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki left review comments

Assignees

@j-piasecki j-piasecki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-gonet @j-piasecki