fix missing testID when createHandler props do not have one assigned #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
j-piasecki
reviewed
Mar 3, 2022
|
Thank you ❤️ ! |
3 tasks
|
Thanks for fixing this @virdesai :) |
|
Lol no problem @vishalnarkhede |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix related to my comment here about
RNGestureHandlerButtonwithhandlerType="NativeViewGestureHandler"having missing testIDs when they were previously provided and assigned. I believe the testID on thechildbeing cloned withincreateHandlerwas being removed by the testID being set within the render function when one was not even passed in. Now it will only assign a testID as a prop on the cloned element if a testID was provided to the handler