Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude unavailable features on tvOS #2618

Closed
wants to merge 3 commits into from

Conversation

mihaiblaga89
Copy link

Description

Following PR #1857, excluded some more unsupported features if the target is tvOS

Test plan

Tested locally with a tvOS app

@ludovic-noirault
Copy link

Using this pull request allows my tvos app to compile 👍

@geroale
Copy link

geroale commented Oct 19, 2023

Looking forward to the merge too!

Copy link

@geroale geroale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m-bert
Copy link
Contributor

m-bert commented Dec 12, 2023

Hi @mihaiblaga89! First of all, thanks for this PR! We must have missed that one and, in response to this issue, we've prepared our own fix.

Given that, I'll close this PR. If you see something that can be improved in our approach, feel free to reopen it.

@m-bert m-bert closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants