Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change .web files to default and add .native (#2835)" #2896

Merged
merged 2 commits into from
May 7, 2024
Merged

Revert "Change .web files to default and add .native (#2835)" #2896

merged 2 commits into from
May 7, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented May 7, 2024 •
edited
Loading

Description

This reverts commit e3e0b79.

#2835 was the first PR that was meant to introduce compatibility with Next.js. Unfortunately, it broke types outside of our repository. Our tsconfig.json has special flag, i.e. moduleSuffixes, which allows tsc to look for .native files first. Most of our users do not have this flag and they've run into ts problems, like this one:

'TextInput' refers to a value, but is being used as a type here. Did you mean 'typeof TextInput'?

Given that removing moduleSuffixes from tsconfig results in a bunch of errors (and there are more of them that we may not be aware of), we decided that it will be better to revert this change for now. It is not necessary since we only need it to support Next.js. At first I thought that #2873 may help, but unfortunately it doesn't.

Fixes #2889

Test plan

  1. Check that web, Android and iOS work as they did before
  2. Check that code from this comment now does not throw any errors

@m-bert m-bert requested a review from j-piasecki May 7, 2024 09:59
This was referenced May 7, 2024
Closed
Merged
@j-piasecki j-piasecki merged commit 8b2470a into main May 7, 2024
1 check passed
@j-piasecki j-piasecki deleted the @mbert/revert-extensions branch May 7, 2024 11:15
@m-bert m-bert mentioned this pull request May 8, 2024
Closed
github-merge-queue bot pushed a commit to valora-inc/wallet that referenced this pull request Jun 6, 2024
@renovate
fix(deps): update dependency react-native-gesture-handler to ^2.16.2 (#…
e696bee 
…5520)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://github.com/software-mansion/react-native-gesture-handler)
| [`^2.16.0` ->
`^2.16.2`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.16.0/2.16.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.16.0/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.16.0/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.16.2`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.16.2)

[Compare
Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.16.1...2.16.2)

##### 🐛 Bug fixes

- Revert "Change `.web` files to default and add `.native`
([#&#8203;2835](https://github.com/software-mansion/react-native-gesture-handler/issues/2835))"
by [@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2896

##### 🔢 Miscellaneous

- Add examples to Gestures section in docs by
[@&#8203;xnameTM](https://github.com/xnameTM) in
[software-mansion/react-native-gesture-handler#2876
- Fix missing styles in gestures' InteractiveExamples by
[@&#8203;patrycjakalinska](https://github.com/patrycjakalinska) in
[software-mansion/react-native-gesture-handler#2897

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.16.1...2.16.2

###
[`v2.16.1`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.16.1)

[Compare
Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.16.0...2.16.1)

#### 🐛 Bug fixes

- Fix remote debugger detection in bridgeless mode by
[@&#8203;piaskowyk](https://github.com/piaskowyk) in
[software-mansion/react-native-gesture-handler#2864
- Fix `manualActivation` on web by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2869
- Fix old Gesture Handler API integration with Reaniamted by
[@&#8203;piaskowyk](https://github.com/piaskowyk) in
[software-mansion/react-native-gesture-handler#2881
- \[Web] Fix incorrect `startX` and `startY` values in `Pan` by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2871
- \[Web] Add `minVelocity` to `Pan` custom activation criteria by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2884

#### 👍 Improvements

- Add `TypeDoc` to new API by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2874

#### 🔢 Miscellaneous

- Bump Gesture Handler version in documentation by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2838
- Change `.web` files to default and add `.native` by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2835
- Bump `typescript` version in example by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2848
- Disable flipper on CI by [@&#8203;m-bert](https://github.com/m-bert)
in
[software-mansion/react-native-gesture-handler#2843
- Update supported RN versions by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2849
- Add state flow charts to Gesture Handler's documentation. by
[@&#8203;latekvo](https://github.com/latekvo) in
[software-mansion/react-native-gesture-handler#2817
- Fix `cancell` typo by [@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2854
- Minor TS changes by [@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2872
- Add automatic og:image generation to docs by
[@&#8203;xnameTM](https://github.com/xnameTM) in
[software-mansion/react-native-gesture-handler#2851
- Fix typo in og:image generation by
[@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) in
[software-mansion/react-native-gesture-handler#2880
- Bump React Native in FabricExample to 0.74 by
[@&#8203;m-bert](https://github.com/m-bert) in
[software-mansion/react-native-gesture-handler#2877
- Update yarn setup in the repository by
[@&#8203;j-piasecki](https://github.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2882
- Release 2.16.1 by
[@&#8203;j-piasecki](https://github.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2883

#### New Contributors

- [@&#8203;xnameTM](https://github.com/xnameTM) made their first
contribution in
[software-mansion/react-native-gesture-handler#2851

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.16.0...2.16.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
@ColeCoffman ColeCoffman mentioned this pull request Jun 6, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Jul 10, 2024
Merged
@toomeem toomeem mentioned this pull request Jul 11, 2024
Merged
@Abellache-Rabah Abellache-Rabah mentioned this pull request Jul 13, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Jul 17, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain classes (ScrollView, RNGHTextInput) no longer exporting type
2 participants
@m-bert @j-piasecki