-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make osx example utilise the common example app #3055
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it won't have much conflicts with #2919 😅
I hope there won't be any, Regardless, this PR is still WIP, and only works on my end due to some modifications to |
…s of transitioning
As of now, the common examples are working on |
I think this is what we wanted to achieve 😅
First one is definitely not a problem. As for second, I have not looked deeply into this configuration, but before you had to start separate metro server for
Sounds good 😄 |
PR functional as of 7717de6 currently only working on making the CI tests pass. |
… config for 0.74, fix podfile for 0.74
At the moment the example app on iOS doesn't build: https://github.com/software-mansion/react-native-gesture-handler/actions/runs/10941427525. (I've also triggered Android just to be sure: https://github.com/software-mansion/react-native-gesture-handler/actions/runs/10941919130). Also, assets are not loading in the macOS app: I would assume this isn't expected, but I also wasn't following the PR that closely. |
I'm working on it. It's caused by presence of
As far as I know, image assets are not available on macos. I'll keep you updated. (cc @j-piasecki) |
Since these problems are caused by |
@j-piasecki Image loading fixed in 2d62e3a and 896f9be. |
… in common example
Description
This PR makes the MacOS example utilise the common example app.
This change will allow for more in-depth testing of MacOS functionalities.
For now, it's still work in progress
Test plan