Add type tests for AnimatedRef and fix Animated Components regression #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
piaskowyk
approved these changes
Oct 30, 2023
tomekzaw
approved these changes
Nov 20, 2023
Latropos
pushed a commit
that referenced
this pull request
Nov 24, 2023
…#5308) Requires #5320. ## Summary I induced a regression accidentally in #5031 regarding FlatList. This PR: - fixes this regression, - improves the type structure of other components, - adds a new test suite to detect such mistakes in the future. It also automatically fixes failing future RN version typecheck CI. ## Test plan All the new & old tests should work.
Latropos
pushed a commit
that referenced
this pull request
Dec 12, 2023
…#5308) Requires #5320. ## Summary I induced a regression accidentally in #5031 regarding FlatList. This PR: - fixes this regression, - improves the type structure of other components, - adds a new test suite to detect such mistakes in the future. It also automatically fixes failing future RN version typecheck CI. ## Test plan All the new & old tests should work.
Latropos
pushed a commit
that referenced
this pull request
Dec 18, 2023
…#5308) Requires #5320. I induced a regression accidentally in #5031 regarding FlatList. This PR: - fixes this regression, - improves the type structure of other components, - adds a new test suite to detect such mistakes in the future. It also automatically fixes failing future RN version typecheck CI. All the new & old tests should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #5320.
Summary
I induced a regression accidentally in #5031 regarding FlatList.
This PR:
It also automatically fixes failing future RN version typecheck CI.
Test plan
All the new & old tests should work.