Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gradle task to automatically copy the codegen artifacts for paper #2168

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions FabricExample/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,5 @@ newArchEnabled=true
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

isScreensExampleApp=true
kkafar marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions FabricTestExample/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ newArchEnabled=true
hermesEnabled=true

disableMultipleInstancesCheck=true

isScreensExampleApp=true
55 changes: 55 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,58 @@ dependencies {
}
}
}

def isScreensExampleApp() {
return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp')
kkafar marked this conversation as resolved.
Show resolved Hide resolved
}

task copyCodegenArtifacts(type: Copy) {
group 'After build tasks'
description 'Tasks which copy codegen artifacts to paper architecture'

if (!isScreensExampleApp()) {
kkafar marked this conversation as resolved.
Show resolved Hide resolved
return
}

dependsOn tasks.generateCodegenArtifactsFromSchema
kkafar marked this conversation as resolved.
Show resolved Hide resolved

def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}"
def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}"
kkafar marked this conversation as resolved.
Show resolved Hide resolved

def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching {
include '**/*.java'
}

def generatedFiles = fileTree(absoluteCodegenArtifactsSource).matching {
include '**/*.java'
}

def existingFilesMap = [:]

existingFiles.forEach { existingFile ->
existingFilesMap[existingFile.name] = 1
}

generatedFiles.forEach { generatedFile ->
if (!existingFilesMap.containsKey(generatedFile.name)) {
println generatedFile.name + " not found in paper dir"
kkafar marked this conversation as resolved.
Show resolved Hide resolved
}
}

if (existingFiles.size() <= 0) {
throw new Exception('Paper destination with codegen interfaces is empty.')
kkafar marked this conversation as resolved.
Show resolved Hide resolved
}
kkafar marked this conversation as resolved.
Show resolved Hide resolved

if (existingFiles.size() > generatedFiles.size()) {
throw new Exception('Number od generated artifacts should be greather then or equal to paper interfaces.')
kkafar marked this conversation as resolved.
Show resolved Hide resolved
}


from absoluteCodegenArtifactsSource
include existingFiles.collect { it.name }
into absoluteCodegenArtifactsPaperDestination
}

if (isScreensExampleApp()) {
tasks.generateCodegenArtifactsFromSchema.finalizedBy('copyCodegenArtifacts')
}
maciekstosio marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 3 additions & 0 deletions android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ android.useAndroidX=true
android.enableJetifier=true

kotlin.code.style=official

codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers
maciekstosio marked this conversation as resolved.
Show resolved Hide resolved
codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/
maciekstosio marked this conversation as resolved.
Show resolved Hide resolved
Loading