Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Android): update spotless & ktlint #2189

Merged
merged 6 commits into from
Jun 19, 2024
Merged

chore(Android): update spotless & ktlint #2189

merged 6 commits into from
Jun 19, 2024

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 17, 2024

Description

Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue.

Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

Checklist

  • Ensured that CI passes

@kkafar kkafar requested review from tboba, maciekstosio and alduzy and removed request for tboba and maciekstosio June 18, 2024 09:41
tboba
tboba approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! Can we also put an update in this PR of distributionUrl field in main gradle-wrapper.properties file, so that we could bump gradle version here as well?

@kkafar
Copy link
Member Author

kkafar commented Jun 18, 2024

Will do it in separate PR

@kkafar
Copy link
Member Author

kkafar commented Jun 18, 2024

besides that it is already bumped to 7.5.1

@tboba
Copy link
Member

tboba commented Jun 18, 2024

Yeah, I've seen that you've bumped it yesterday 😄 nevermind

kkafar
kkafar commented Jun 19, 2024
View reviewed changes
Copy link
Member Author

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the code to make sure whether there are no semantics changes it all seems ok.

@kkafar kkafar merged commit c018d75 into main Jun 19, 2024
3 of 4 checks passed
@kkafar kkafar deleted the @kkafar/android-linter-2 branch June 19, 2024 11:11
alduzy pushed a commit that referenced this pull request Jun 28, 2024
@kkafar @alduzy
chore(Android): update spotless & ktlint (#2189)
c1373d6 
## Description

Encountered some errors (seems they were looking for old CMake version
(3.10.2)) & decided to bump these deps as they are long overdue.

## Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

## Checklist

- [ ] Ensured that CI passes
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
@2lambda123 2lambda123 mentioned this pull request Aug 26, 2024
Merged
@shonore shonore mentioned this pull request Aug 27, 2024
Open
This was referenced Aug 28, 2024
Open
Open
Open
Open
Open
Open
Open
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 22, 2024
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboba tboba tboba approved these changes

@alduzy alduzy Awaiting requested review from alduzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkafar @tboba