Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): missing negation in check for mismatched frames #2214

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix(Android): missing negation in check for mismatched frames #2214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class RNSScreenComponentDescriptor final
// state update.
if (screenShadowNode.getFrameCorrectionModes().check(
FrameCorrectionModes::Mode::FrameHeightCorrection) &&
compareFrameSizes(
!compareFrameSizes(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider changing the name of this function to something like checkIsFrameSizeEqual so that it's obvious what it returns.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good suggestion. compare may suggest inequality, right?
I'll do it in separate PR, thanks!

screenShadowNode.layoutMetrics_.frame.size,
stateData.frameSize)) {
LOG(ERROR)
Expand Down
Loading