-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Android): add ios like ios_from_left
slide animation
#2328
feat(Android): add ios like ios_from_left
slide animation
#2328
Conversation
We should discuss how we want to name these two "ios-like" animations. Before there was only I feel like this is the more consistent approach, compared to the other animations that exist. This would be a breaking change for apps that currently use |
ios_from_left
slide animation ios_from_left
slide animation
ios_from_left
slide animation ios_from_left
slide animation
Hey @chrispader, thanks a lot for a contribution 🙌🏻 I think we might want to take a backwardcompatible approach. Let's keep the old |
sounds good! @kkafar |
Just added back the I also added a depreaction warnings to the comments for |
1f9ce7d
to
b6130c7
Compare
Thanks @chrispader, we just waiting for me to have time to test this & I believe we can merge. Thank you! |
@kkafar no hurries. We already got this working through a patch in https://github.com/Expensify/App, so this is really only a feature addition to RNS :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing 🎉
Description
This PR is based on #1945 and implements the
ios
animation in the reverse direction (slide in from left to right, slide out from right to left)Changes
Test code and steps to reproduce
Checklist