Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): getChildDrawingOrder when using refreshcontrol #2330

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

BenIrving
Copy link
Contributor

@BenIrving BenIrving commented Sep 2, 2024

Description

Fixes #2329

Changes

  • Changes how we check if the child is a CircleImageView to be minification safe

Test code and steps to reproduce

Build [this](https://github.com/BenIrving/refreshcontrolrepro/tree/main) repro using this changeset, observe no crash when navigating between screens.

You can also check Test640.tsx test by going into the second screen (by button), then try to manually refresh list by swiping down (until the refresh control will show). During the refresh, try to go back to the first screen - application shouldn't crash.

Checklist

  • Ensured that CI passes

@tboba tboba self-requested a review September 3, 2024 10:09
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 😄

@tboba tboba merged commit d424e1a into software-mansion:main Sep 3, 2024
4 checks passed
@BenIrving BenIrving deleted the circle-image-view branch September 3, 2024 19:09
@renyufei8023
Copy link

It doesn't work for me
react native@0.75.3
react native screens@3.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefreshControl IndexOutOfBoundsException: getChildDrawingOrder() crash
3 participants