Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add replace animation #486

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Apr 29, 2020

Added animation options for replace action. At the update of the container, if the previous top screen is no longer on the stack and the new screen was not there before, it probably means that replace action was invoked, so we choose the animation of the new screen. Should close #394.

@enheit
Copy link

enheit commented Jun 17, 2020

@WoLewicki @kmagiera any updates on this pull request?

@WoLewicki
Copy link
Member Author

@enheit you can always add it to your project via patch-package if you need it. It will be merged in the near future probably.

@WoLewicki WoLewicki force-pushed the @wolewicki/add-replace-animations branch from 8bfbd0a to 0acdcf5 Compare July 28, 2020 08:12
@WoLewicki WoLewicki force-pushed the @wolewicki/add-replace-animations branch from 0acdcf5 to 78b99cd Compare August 4, 2020 08:51
@WoLewicki WoLewicki force-pushed the @wolewicki/add-replace-animations branch from ffba0eb to 202d373 Compare August 5, 2020 09:20
@WoLewicki WoLewicki merged commit 6260431 into master Aug 5, 2020
@WoLewicki WoLewicki deleted the @wolewicki/add-replace-animations branch August 5, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add animationTypeForReplace
2 participants